GithubHelp home page GithubHelp logo

Comments (3)

DvdMgr avatar DvdMgr commented on September 4, 2024

Thanks for pointing this out.

Actually, frame counters have not been implemented/tested so far, as their behavior does not impact the outcome of simulations we are interested in. If you want to implement them correctly also at the NetworkServer, please submit a pull request and I'll look into it! Otherwise, I can just remove the line you pointed out to fix this.

from lorawan.

gaurivn avatar gaurivn commented on September 4, 2024

On clicking the link provided in the issue, it says page not found, could you please provide the working link

Expected Behavior

Same as title.
According to lorawan spec 1.0.3 (https://lora-alliance.org/sites/default/files/2018-07/lorawan1.0.3.pdf), section **4.3.1.5 ** (ln 520-530) seems to suggest retransmitted frame's Fcnt should not be incremented. Similar idea is expressed in sect 4.3.1.1 ln 443-444.

Actual Behavior

end-device-lorawan-mac.cc line 291: m_currentFCnt++;

Steps to Reproduce the Problem

N/A

Specifications

N/A

from lorawan.

DvdMgr avatar DvdMgr commented on September 4, 2024

Hi, searching in the LoRa Alliance website for the 1.0.3 specification as the url suggests brings up this updated link.

from lorawan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.