Comments (3)
Thanks for pointing this out.
Actually, frame counters have not been implemented/tested so far, as their behavior does not impact the outcome of simulations we are interested in. If you want to implement them correctly also at the NetworkServer
, please submit a pull request and I'll look into it! Otherwise, I can just remove the line you pointed out to fix this.
from lorawan.
On clicking the link provided in the issue, it says page not found, could you please provide the working link
Expected Behavior
Same as title.
According to lorawan spec 1.0.3 (https://lora-alliance.org/sites/default/files/2018-07/lorawan1.0.3.pdf), section **4.3.1.5 ** (ln 520-530) seems to suggest retransmitted frame's Fcnt should not be incremented. Similar idea is expressed in sect 4.3.1.1 ln 443-444.Actual Behavior
end-device-lorawan-mac.cc line 291: m_currentFCnt++;
Steps to Reproduce the Problem
N/A
Specifications
N/A
from lorawan.
Hi, searching in the LoRa Alliance website for the 1.0.3 specification as the url suggests brings up this updated link.
from lorawan.
Related Issues (20)
- Useless comments
- bash: ./waf: No such file or directory HOT 5
- Are the max packet sizes correct? HOT 1
- How does lorawan-energy-model-example.cc suppose to work ?
- Simulation with LoRa (without LoRaWAN stack)
- LoRa Mesh module contribution?
- Lack of maintenance + alternatives
- lorawan: Ongoing changes to the module
- Issue with LoraFrameHeader while Handling the address part in LoRaWAN MAC Layer for Multiple End Devices
- test.py failing with "Packet changed contents when going through the channel" HOT 3
- m_receiveCallback in Receive function in lora-net-device HOT 4
- Performance metrics HOT 2
- Questions about complete network example HOT 3
- lorawan module paccket indicated as lost and received successfully at the same time HOT 2
- Unable to read LoraFrameHeader for uplink messages (using gw mac) HOT 2
- Broken documentation HOT 2
- How to run a simple scenario in aloha , slotted aloha and tdma? HOT 1
- How to integrate a new model HOT 2
- Transmission disappearing when sent before second Rx window HOT 2
- onoffhelper HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lorawan.