GithubHelp home page GithubHelp logo

Clarify enr content value format about enr HOT 1 CLOSED

sigp avatar sigp commented on August 31, 2024
Clarify enr content value format

from enr.

Comments (1)

AgeManning avatar AgeManning commented on August 31, 2024

To be generic across all types we store the underlying data as bytes and convert to specific types later one.

The general spec indicates an RLP list of k,v: https://github.com/ethereum/devp2p/blob/master/enr.md#rlp-encoding

In principle, it should work for any object that is RLP encodable. In your test could you not just put the fork_id into add_value() and it will be encoded as every other type that is rlp encodeable and stored in the ENR.

Your suggestion would be to double rlp-encode objects right?
Currently we are just rlp-encoding the types and storing the bytes of the rlp-encoded object, which seems sensible to me.

Unless the .build() fails on normal types, it should be the case that all rlp-bytes can be decoded as bytes right?

from enr.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.