Comments (4)
Fixed by #37. The problem is in this code:
Lines 1122 to 1129 in cbf1289
The mere existence of mem::uninitialized()
of a generic type is already undefined behavior. It's not clear how bad it is in practice exactly if this memory is never read. However, the definitely practical issue comes from the fact that a panic may happen on line 1127, before reaching mem::forget()
, because the underlying reader provided by the API client may panic. It the panic occurs, drop()
is called on the uninitialized memory, which is equivalent to a use-after-free bug, and use-after-free bugs are often exploitable.
from libflate.
The issue was introduced in commit deadd75 and affects releases 0.1.14 and onwards until the fix in 0.1.25.
@sile please yank versions 0.1.14 to 0.1.24 inclusive from crates.io. I'll handle the security advisory.
from libflate.
please yank versions 0.1.14 to 0.1.24 inclusive from crates.io.
Done. Thank you for your contribution and advice.
from libflate.
Closing now that the fix is released, vulnerable versions are yanked and a security advisory is filed.
from libflate.
Related Issues (20)
- zlib::Encoder flush() behavior HOT 2
- Private function prefix() is unsound HOT 1
- Decoder::read_non_compressed_block() is unsound HOT 4
- Decoder may expose contents of uninitialized memory in the output HOT 5
- Remove byteorder-dependency HOT 1
- Possible concurrency issue during deflate on libflate 0.1.25 HOT 8
- Convenience functions? HOT 1
- btype 0x11 of DEFLATE is reserved(error) value HOT 1
- LZ77 compressor as a separate crate? HOT 3
- libflate 1.0.0 is on crates.io, but not here HOT 1
- Encoder panic on specific input data... HOT 1
- Compression level HOT 5
- UnexpectedEof encountered when decompressing data HOT 4
- Streaming data extensions HOT 4
- LZ77 decoder? HOT 2
- libflate::gzip::Decoder::read does not handle zero-length buffer properly HOT 2
- UB in the public safe API - where to report? HOT 4
- Panic in `bug` when parsing malformed file HOT 4
- GzDecoder seem decode incorrect HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libflate.