GithubHelp home page GithubHelp logo

Comments (8)

hesselink avatar hesselink commented on June 15, 2024

Isn't this just how the backends handle exceptions by default?

from rest.

bergmark avatar bergmark commented on June 15, 2024

Probably, but I think we should change it. At the moment a lot of errors are lost when using rest-happstack.

from rest.

dpwiz avatar dpwiz commented on June 15, 2024

Take a note that error messages can leak sensitive information...

from rest.

hesselink avatar hesselink commented on June 15, 2024

So this is an issue mostly with happstack, because it uses lazy bytestrings. That means that if there is an undefined or something in the computation that produces a response, you might lose the error, even if you have a top level exception handler around your code. rest inherits this limitation, since it also uses a lazy bytestring. So I think it's up to users to handle this, with a top level exception handler and optionally forcing the response body if you want to be sure you catch everything.

from rest.

bergmark avatar bergmark commented on June 15, 2024

Is there anything we can actually do about this in rest? It sounds to me that users just have to pick a backend that does this properly. We can probably close this.

from rest.

hesselink avatar hesselink commented on June 15, 2024

We could switch rest to use some kind of streaming abstraction (pipes, conduit, io-streams). Then I think wai and snap could handle this correctly. I'm not sure how much work this would be. A lot of it would just be choosing what to use and seeing how it impacts the whole framework, I guess.

from rest.

bergmark avatar bergmark commented on June 15, 2024

wai already does this well enough, and snap-1.0 should also fix it.

from rest.

hesselink avatar hesselink commented on June 15, 2024

OK, let's close it then.

from rest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.