Comments (5)
It's definitely the safer way how it currently is though I agree the code may not match the comment/the intended use.
from silverstripe-framework.
Please avoid using images when referencing code - just the link to the code is sufficient, or use codeblocks if you really want to include the code in the issue itself.
from silverstripe-framework.
Looks like in this commit (back in the SilverStripe 2 days) a refactor accidentally missed out the true
from the return statement, and then later in this commit (very early Silverstripe 4) another refactor added false
which probably seemed like the correct value to return without checking the PHPDoc.
Given it's been wrong since Silverstripe 2 I'm inclined to agree that the strict check should just be removed. It can be removed in 5.x without any BC changes since it ultimately returns false either way once you get to that part of the code. The parameter itself should be deprecated, to be removed in 6.
from silverstripe-framework.
will you make the changes?
from silverstripe-framework.
There are over 2000 issues across the supported modules, and three total people on the CMS Squad. I can't commit to saying I or anyone on the CMS Squad will make changes for any given issue unless it has a high or critical impact.
from silverstripe-framework.
Related Issues (20)
- text collector doesn't collect when parameters are passed as a variable HOT 3
- SearchableDropdownTrait::getSource doesn't respect lazy-loading HOT 5
- SQLSelect regression with subqueries HOT 16
- Deprecated getIterator function called in SSViewer_Scope HOT 2
- Remember Me functionality fails when renewal is interrupted HOT 10
- SearchableDropdownTrait::saveInto calls DataObject::write HOT 4
- Sake script failure when PHP binary path contains spaces in SilverStripe 5.2.2 HOT 1
- Drop support for MySQL 5 in CMS 6 HOT 2
- `performReadonlyTransformation()` for `SearchableDropdownField` and `SearchableMultiDropdownField` doesn't respect lazy loading HOT 4
- DBForeignKey scaffolding uses wrong parameters to create SearchableDropdownField HOT 1
- HTMLValue setContent preg_replace stripping <header> tags HOT 1
- Revert Truncate table to clear table HOT 1
- Deprecate `DB::USE_ANSI_SQL` HOT 2
- Abstract template layer into its own dedicated module HOT 7
- PHPLinting failure
- Chained properties result in errors if TemplateGlobalProvider returns `null`
- Coerce DBBoolean to be actually be a boolean HOT 3
- $themedir not work in silverstripe 5 HOT 1
- CMS6: Default to utf8mb4 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from silverstripe-framework.