Setting output precision for String::String(const T& t) about simbody

[sherm1]

Hi, Clay! This seems like a good fix, thanks. My first thought is -- why not just change the output to lossless and not add a precision parameter? If there is no immediate need for reduced precision, let's not add the extra complexity. It could always be added later if a necessary use case is discovered. I don't think reduced file size is a compelling need.

With no additional parameter, I don't think a new unit test would be required. With an API change, I do think a small test would be required to ensure that it works and keeps working in the future.

Regards, Sherm

[fcanderson]

Sherm, thanks for the response. What you suggest { just changing the output to lossless always } would be simplest. And, as you say, it can change later pretty simply if a need arises.

Do you care about how I deal with the trailing whitespace in String.h?

I am inclined to do two PRs:
PR1 to get rid of the trailing whitespace in String.h (and perhaps also Xml.h), and
PR2 to make the output precision change to lossless.

[sherm1]

Two PRs would be ideal, thanks.

[fcanderson]

#776 and #779 add the capacity to convert numerical types to SimTK::Strings and Xml::Element values.