GithubHelp home page GithubHelp logo

count_code_points about simdutf HOT 5 CLOSED

alantudyk avatar alantudyk commented on June 12, 2024
count_code_points

from simdutf.

Comments (5)

lemire avatar lemire commented on June 12, 2024 2

@Nick-Nuon Want to have a look?

from simdutf.

lemire avatar lemire commented on June 12, 2024

Want to issue a pull request? Iā€™m curious as to whether it would have a visible performance difference.

from simdutf.

alantudyk avatar alantudyk commented on June 12, 2024

pull request?

No.

from simdutf.

lemire avatar lemire commented on June 12, 2024

@alantudyk So as I expected, it does not affect the performance. We will still follow on your proposal because it slightly simplifies the code which is good from a software engineering point of view (better readability).

Thanks @Nick-Nuon

from simdutf.

alantudyk avatar alantudyk commented on June 12, 2024

simd8x64<int8_t> input(reinterpret_cast<const int8_t *>(in + pos));
uint64_t utf8_continuation_mask = input.gt(-65);
count += count_ones(utf8_continuation_mask);

Missing space (L15).

You should add any formatter / style checker to CI.

from simdutf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.