Memory accumulation with QtPromise timeouts and QNetworkAccessManager about qtpromise

[simonbrunel]

Hi @wjHunter!

I would move reply out of the QPromise constructor and use finally (always called) to delete the reply (thus would not rely on QNetworkRequest::AutoDeleteReplyOnFinishAttribute). I would also probably use QtPromise::connect instead of the QPromise constructor. For example:

QtPromise::QPromise<QByteArray> request(QNetworkAccessManager& network, const QUrl& endpoint)
{
  auto reply = network.get(QNetworkRequest{endpoint});
  return QtPromise::connect(reply, &QNetworkReply::finished)
    .timeout(250)
    .then([reply]() {
      if (reply->error() != QNetworkReply::NoError) {
        throw reply->error();
      }
      return reply->readAll();
   })
   .finally([reply]() {
     reply->deleteLater();
   });
}

[wjHunter]

Thank you for the very quick reply