Comments (2)
I started looking into this and reworking all the other code related to paddings, but I've noticed that #8 has changed some margins, at least on the main screen. For example here's before and after with compact header:
Before | After |
---|---|
![]() |
![]() |
There are also some differences with tablets. Which version should I match?
from harmonic-hn.
The left version is definitively the one to go for, that is the way it used to look.
Really glad you are digging into the paddings! I'm currently fixing the squished icons issue by reworking the bottom sheet margins but the rest would be great.
from harmonic-hn.
Related Issues (20)
- Integrated WebView blank after unfolding HOT 3
- Filter stories with less points than X
- Dialogs with discard button do not adhere to Material guidelines HOT 1
- Early text cutoff when collapsed HOT 2
- Clicking links should optionally be redirected to Nitter as well HOT 2
- Swiping back twice glitches HOT 10
- Deprecate Nitter integration HOT 1
- Can't remove unloading item from bookmarks HOT 3
- WebView crashes if Harmonic waits too long on the background. HOT 2
- Search locally askHN comments HOT 4
- Add option for pagination
- Cap scroll animation length HOT 2
- Push Tag HOT 1
- Post translator support
- Comment header HOT 2
- Polls not showing when coming from Algolia (search/submissions) HOT 1
- Comment count disappearing when doing fold/unfold HOT 1
- Folded comment count not updating HOT 1
- Clarify vote direction in toast HOT 2
- Question: Comment search and archive.org only available with WebView HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from harmonic-hn.