GithubHelp home page GithubHelp logo

Comments (4)

adriaandotcom avatar adriaandotcom commented on May 26, 2024 1

Thanks for investigating this! Will update the script when I'm back from my holiday.

Maybe a better solution would be using sendBeacon directly:

nav.sendBeacon(
  fullApiUrl + "/append",
  stringify(assign(payload, append))
);

We don't need to size optimization if we need apply or call anyway.

from scripts.

Jivings avatar Jivings commented on May 26, 2024

I think it's because you can't use the navigator object as a reference without binding it's scope. So you should be invoking it with call or apply.

nav[sendBeaconText].call(
  nav, 
  fullApiUrl + "/append",
  stringify(assign(payload, append))
);

So for example this doesn't work:

image

But this does:

image

from scripts.

Jivings avatar Jivings commented on May 26, 2024

Yes that should be fine.

from scripts.

adriaandotcom avatar adriaandotcom commented on May 26, 2024

Fixed in #29

from scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.