GithubHelp home page GithubHelp logo

Comments (9)

quix avatar quix commented on July 30, 2024

I have been making the same change whenever I install simplecov. If some people actually need that line, perhaps something like this could work:

if File.file? "Gemfile"
  require 'bundler'
  Bundler.setup(:default)
end

from simplecov-html.

jstepien avatar jstepien commented on July 30, 2024

Thanks, it seems like a reasonable solution. Christoph, could you add it to the next release?

from simplecov-html.

Burgestrand avatar Burgestrand commented on July 30, 2024

Bundler is not even in the gem dependencies; not to mention it unloads rspec for me as I have a Gemfile where rspec is nothing but a development dependency.

from simplecov-html.

mfn avatar mfn commented on July 30, 2024

As a first time simplecov user I stumbled into this to and was quite irritated by it. I only have a small project and don't even know what the Gemfile is and why I need it. It would be nice if whatever features it provides it would be opt-in, as it seems the file is not really necessary as it can be empty.

from simplecov-html.

luislavena avatar luislavena commented on July 30, 2024

Hello, I've been hit by this too.

If you use Bundler for development, it should not be as part of your library. Not everybody uses Bundler or likes to depend on it at runtime

Perhaps will be better you move bundler and it's requires to your Rakefile only and use for development purposes, which is great.

Also, seems that simplecov-html is depending, at the code level, on simplecov gem be present (and even required):

https://github.com/colszowka/simplecov-html/blob/master/lib/simplecov-html.rb#L14-17

But simplecov is not defined as runtime dependency of the gem:

https://github.com/colszowka/simplecov-html/blob/master/simplecov-html.gemspec

But is been required in the Gemfile as development and also references via gemspec

Would you accept a patch/pull request that normalizes this?

from simplecov-html.

luislavena avatar luislavena commented on July 30, 2024

I just submitted pull request #8 which corrects this. Please apply.

Thank you.

from simplecov-html.

david-mccullars avatar david-mccullars commented on July 30, 2024

Any idea when we'll get an updated gem with this? or even a pre-release gem?

from simplecov-html.

colszowka avatar colszowka commented on July 30, 2024

I will push this tomorrow, sorry for the delay!

from simplecov-html.

colszowka avatar colszowka commented on July 30, 2024

Forget what I just said, simplecov-html 0.4.5 is out. Thanks to @luislavena for the fix and everyone else for the reports and patience!

from simplecov-html.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.