GithubHelp home page GithubHelp logo

Comments (5)

cschneid avatar cschneid commented on May 19, 2024

Is this still valid? And do we have the patch?

Here's what the spec says:

10.4.6 405 Method Not Allowed

The method specified in the Request-Line is not allowed for the
 resource identified by the Request-URI. The response MUST include an
Allow header containing a list of valid methods for the requested
resource.

So we'd need to have a "not_found" chunk of code that runs when no route matches, that tries the lookup for all other kinds of HTTP methods, keeping track of which ones do in fact match. Build the Accepts header, and then send that back down the pipe as a 405.

from sinatra.

rkh avatar rkh commented on May 19, 2024

There is an experimental patch in rkh/bad_method, but it comes at performance/memory cost.

from sinatra.

robertbeal avatar robertbeal commented on May 19, 2024

Was this every patched? It still seems to be an issue.

from sinatra.

rkh avatar rkh commented on May 19, 2024

No, it was never patched. We might tackle this in 2.0.

from sinatra.

drum445 avatar drum445 commented on May 19, 2024

@rkh was this ever fixed?

from sinatra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.