GithubHelp home page GithubHelp logo

Comments (2)

sinclairzx81 avatar sinclairzx81 commented on July 30, 2024 1

@MatthewAry Hiya,

Have pushed a fix for this on 0.32.34. You should be able to embed template within templates as per your original example. The following should map as you expect (note: you may need to clear your browser cache)

TypeScript Link Here

This issue was specific to the inference, where the runtime mapping was working as expected. TypeBox is due to revisit the template literal implementation under the revised inference architecture (which was added on 0.32.x), there's are still known issues with embedding unions in unions in template literals in unions (or some nested permutation of) (which is technically possible in TS, but quite challenging to map), This said, supporting embedded template literals in template literals was envisioned for the first pass of this feature (so thanks for finding this)

If you run into any issues, feel free to ping on this thread.
Cheers
S

from typebox.

sinclairzx81 avatar sinclairzx81 commented on July 30, 2024

@MatthewAry Hi, thanks for reporting!

On mappingType, I expected the result to match to:

You can get this to work with the following.

TypeScript Link Here

function baseNumericComparableLiteral<T extends string>(key: T) {
  // avoid embedding template literal in template literal
  return Type.TemplateLiteral([Type.Literal(key), Type.Union([ 
    Type.Literal('gt'),
    Type.Literal('gte'),
    Type.Literal('lt'),
    Type.Literal('lte'),
    Type.Literal('eq'),
    Type.Literal('ne'),
  ])])
}

const literals = baseNumericComparableLiteral('key')
type literalsType = Static<typeof literals> // type literalsType = "keygt" | "keygte" | "keylt" | "keylte" | "keyeq" | "keyne"

const mapping = Type.Mapped(literals, K => Type.Date())
type mappingType = Static<typeof mapping> // {
                                          //  "keygt": Date
                                          //  "keygte": Date
                                          //  "keylt": Date
                                          //  "keylte": Date
                                          //  "keyeq": Date
                                          //  "keyne": Date
                                          // }

However I would expect the embedded template literal (as per your example), to correctly map also. I will take a look at this.

Let me know if the above helps
Cheers
S

from typebox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.