Support for HTTP headers about electron-dl

[joaomvfsantos]

I understand your point, I also agree this should be part of the DownloadItem, so an electron issue.

Just for reference, may be interesting to someone, as a workaround I'm using the onBeforeSendHeaders method off the default session's webRequest. This affects all requests which falls within the filter definition. Works for my use case, but maybe does not cover all.

[sindresorhus]

I don't see any API for that in Electron: https://electron.atom.io/docs/api/download-item/

So you would have to get it added to Electron first: https://github.com/electron/electron/issues

(Please comment the Electron issue here if you do)

[ericpyle]

There was an issue (electron/electron#10582) made for Electron, but it got closed becaused they considered it to be a question rather than a feature request.

One contributor in that issue said

DownloadItem is handled by the Download Manager, the only API that seems to work with the download manager is contents.downloadURL(url):
https://github.com/electron/electron/blob/master/docs/api/web-contents.md#contentsdownloadurlurl

Looking at the C++ binding only a URL is allowed to be passed into the function:

electron/atom/browser/api/atom_api_web_contents.cc
Line 1061 in cc9771a

 void WebContents::DownloadURL(const GURL& url) { 

For allowing custom headers etc. to work an extension to the downloadURL function needs to be implemented.

[sindresorhus]

Closing in favor of electron/electron#12883