Comments (3)
After looking into this a bit more, I'm less convinced it's a gulp-jasmine problem, but simply an artifact of how Node streams handle errors. This post by the author of gulp-plumber was enlightening.
So another possible solution would be (from here):
return gulp.src('spec/**/*.spec.js')
.pipe(jasmine())
.on('error', (err) => {
gutil.log(err)
process.exit(1)
})
.pipe(istanbul.writeReports())
Note that gulp-plumber's default error handler does not exit the process, so if you want a nonzero exit code, you still have to pass it a custom error handler that will explicitly exit the process.
One more observation that made me think this was originally a gulp-jasmine problem... If I use gulp-mocha instead of gulp-jasmine, I get the behavior I want of Gulp exiting with a nonzero status when a test fails. Looking at the implementation of gulp-mocha, it uses Node domains to keep track of errors that may occur through a chain of streams, similar to what gulp-plumber does. I suppose gulp-jasmine could be written in such a way, as well, so that it Just Works in the scenario discussed in this issue. However, I don't know if this would limit other use cases where the user wants more flexibility on how plugin errors should be handled (see this article for an example).
from gulp-jasmine.
if you want to exit forcefully use below code
gulp.doneCallback = function(err) {
process.exit(err ? 1 : 0);
};
from gulp-jasmine.
I just ran into this, as well. I don't know the root cause, but it has something to do with piping the results of jasmine()
into a subsequent stream. For example, the following task body will cause Gulp to fail (i.e. exit code != 0) when a test fails:
return gulp.src('spec/**/*.spec.js')
.pipe(jasmine())
However, simply piping the results into any other stream will not cause Gulp to fail (i.e. exit code = 0) when a test fails:
return gulp.src('spec/**/*.spec.js')
.pipe(jasmine())
.pipe(gutil.noop())
I worked around this with my Jasmine/Istanbul integration by promisifying the task body so that I can isolate the Jasmine execution such that nothing needs to be piped downstream of jasmine()
:
const streamToPromise = require('stream-to-promise')
gulp.task('test', () => {
return streamToPromise(
gulp.src('lib/**/*.js')
.pipe(istanbul())
.pipe(istanbul.hookRequire())
)
.then(() => streamToPromise(
gulp.src('spec/**/*.spec.js')
.pipe(jasmine())
))
.then(() => streamToPromise(
gulp.src([])
.pipe(istanbul.writeReports())
))
})
The third promise is a bit of a hack, as I had to use gulp.src([])
to create a dummy empty stream that I can pipe in order to write the Istanbul reports.
I'm pretty sure the same thing could be done without promises by simply creating a series of three dependent tasks (instead of the normal two the gulp-istanbul plugin suggests). For example (please forgive the useless and misleading task names):
gulp.task('pre-pre-test', () => {
return gulp.src('lib/**/*.js')
.pipe(istanbul())
.pipe(istanbul.hookRequire())
})
gulp.task('pre-test', ['pre-pre-test'], () => {
return gulp.src('spec/**/*.spec.js')
.pipe(jasmine())
})
gulp.task('test', ['pre-test'], () => {
return gulp.src([])
.pipe(istanbul.writeReports())
})
from gulp-jasmine.
Related Issues (20)
- Unable to give references of file needed in specs from gulpfile.js
- Issue DEPRECATION : Setting randomizeTests directly is deprecated, please use the random option in `configure`
- Update Jasmine to 3.4 HOT 2
- Upgrade to jasmine 4 HOT 3
- issues with require caching HOT 4
- export jasmine object HOT 9
- Replace silent reporter with onComplete callback
- Error trying to use config in Node 6
- Broken with Jasmine 2.5.0? HOT 9
- Config option for custom Jasmine-instance HOT 4
- gulp-jasmine runs the tests twice when Jasmine version is 2.5.2 HOT 3
- Tests that should fail pass using gulp-jasmine HOT 1
- jasmine doesn't seem to run HOT 1
- Jasmine never getting called if over 16 files loaded HOT 2
- jasmineDone event not called when tests fail
- Cannot load module using require.
- deleteRequireCache blows the stack for circlular referenced files HOT 3
- MaxListenersExceededWarning: Possible EventEmitter memory leak detected. HOT 1
- Running a focused test throws an error when it shouldn't. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gulp-jasmine.