Comments (6)
I thought it was a good idea when I merged #1, but I noticed the issue with AVA too a while ago.
Do you have any suggested solution other than reverting?
// @mastilver
from observable-to-promise.
the Promise.resolve is just there if you pass something which is not an observable
We could just check if the arg is not an observable
, neither a function
If you are happy with that, I will create a PR in 5-6 hours
from observable-to-promise.
Or we could only support observable
and return the passed arg (as it was before my changes)
then you won't be able to do:
observable-to-promise(2).then(x => {
console.log(x);
// => 2
});
will throw Uncaught TypeError: then is not a function
from observable-to-promise.
My only other thought was to throw a TypeError, if they pass a non observable.
It would require AVA do an is-observable
test (so things would be a bit more verbose within AVA). However, I think it's a good change because then this API much more clear.
from observable-to-promise.
throw a TypeError
I'm happy with that
from observable-to-promise.
throw a TypeError
👍
from observable-to-promise.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from observable-to-promise.