Comments (12)
I want to pick this one up as I need it :). Will try to assign some of my time to it.
from ow.
Have you thought about how we could do this? Should we create one ArgumentError
with a list of error messages? Or should we create one ArgumentError
per error and wrap it inside another error?
It's pretty straight forward to implement, we just have to come up with the best way of doing this :).
from ow.
The error is meant for humans, so I think it should just be a nicely formatted text list of error messages in the returned error.message
.
from ow.
@issuehuntfest has funded $60.00 to this issue. See it on IssueHunt
from ow.
Any progress on this one ? @SamVerschueren are you still on this issue ? Seems like a nice feature and fun pretty fun to check it out. Question is do we want this as default behavior or should there be some config triggering this behavior ? It seems like a breaking change though if we default
from ow.
It should be the default. We can consider making it opt-out if someone complains.
Keep in mind: This issue has a bounty, so it's expected that the person working on this does a good effort on it.
from ow.
Hey! I think I'll actually look into this tomorrow (and include a fix for that TODO 👀) if that's ok. Is anyone else working on this? If so, I don't wanna step over their work
from ow.
No one is working on this. Just know that this issue has a bounty, so it's expected that you to do a good effort and think through the problem thoroughly. Also tests and docs.
from ow.
@sindresorhus has rewarded $54.00 to @vladfrangu. See it on IssueHunt
- 💰 Total deposit: $60.00
- 🎉 Repository reward(0%): $0.00
- 🔧 Service fee(10%): $6.00
from ow.
Would it be possible to also report multiple errors if the object doesn't match?
Current behavior:
> ow({a: 2, b: 'a'}, ow.object.exactShape({a: ow.string, b: ow.number}))
Uncaught:
ArgumentError: Expected property `a` to be of type `string` but received type `number` in object
at ow (/Users/k/p/courses/node_modules/ow/dist/index.js:29:28) {
validationErrors: Map(1) {
'object' => Set(1) {
'Expected property `a` to be of type `string` but received type `number` in object'
}
}
}
> ow({a: '2', b: 'a'}, ow.object.exactShape({a: ow.string, b: ow.number}))
Uncaught:
ArgumentError: Expected property `b` to be of type `number` but received type `string` in object
at ow (/Users/k/p/courses/node_modules/ow/dist/index.js:29:28) {
validationErrors: Map(1) {
'object' => Set(1) {
'Expected property `b` to be of type `number` but received type `string` in object'
}
}
}
Suggested behavior:
> ow({a: 2, b: 'a'}, ow.object.exactShape({a: ow.string, b: ow.number}))
Uncaught:
ArgumentError: Expected property `a` to be of type `string` but received type `number` in object
Expected property `b` to be of type `number` but received type `string` in object
at ow (/Users/k/p/courses/node_modules/ow/dist/index.js:29:28) {
validationErrors: Map(1) {
'object' => Set(2) {
'Expected property `a` to be of type `string` but received type `number` in object',
'Expected property `b` to be of type `number` but received type `string` in object'
}
}
}
Even nicer would be to get the errors back in the shape of the original object:
> ow({a: 2, b: 'a'}, ow.object.exactShape({a: ow.string, b: ow.number}))
Uncaught:
ArgumentError: Expected property `a` to be of type `string` but received type `number` in object
Expected property `b` to be of type `number` but received type `string` in object
at ow (/Users/k/p/courses/node_modules/ow/dist/index.js:29:28) {
validationErrors: Object {
a: 'Expected property `a` to be of type `string` but received type `number` in object',
b: 'Expected property `b` to be of type `number` but received type `string` in object'
}
}
from ow.
It's in general better to open a new issue than to comment on old closed issues.
from ow.
Definitely agree, just wanted to get the sentiment of the team before taking the effort to open a new issue.
But if it's preferred to have that discussion elsewhere, understood.
Created a new issue: #237
from ow.
Related Issues (20)
- Bug: `isValid` wrong typing HOT 3
- Package does not seem to work on node v8 `SyntaxError: Unexpected token {` HOT 1
- string.nonBlank validator HOT 1
- Error running with metro bundler
- generate objects from predicate HOT 3
- use browser-side HOT 1
- Unclear error message when checking NaN against the number type HOT 7
- Composition HOT 3
- Is there a way for an object predicate to differentiate between key with value `undefined`, and key not present? HOT 2
- should `ow.string.equals` be narrowing the type to specific strings? HOT 1
- wrong message: Expected `e` to be of type .... - instead of Expected argument to be of type HOT 3
- Show all possible errors exhaustively (option?)
- const values HOT 1
- Q: how to make custom type narrowing validator (i.e. Predicate<x>)? HOT 3
- metadata
- Documentation is 404
- Build errors when using ow in React app compiled with vite
- Upgrading to 1.1.0 from older version makes TS complain HOT 6
- correct pattern for optional 'required' properties?
- Cannot find module 'ow' or its corresponding type declarations HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ow.