GithubHelp home page GithubHelp logo

Comments (2)

sindresorhus avatar sindresorhus commented on June 9, 2024 1

Sure

from settings.

Kyle-Ye avatar Kyle-Ye commented on June 9, 2024

Under the hood, Pane just pass the title property to PaneHostingController and then used in NSWindow and NSToolbarItem which only accepts String.

public convenience init(pane: Pane<Content>) {
self.init(
identifier: pane.identifier,
title: pane.title,
toolbarIcon: pane.toolbarIcon,
content: pane.content
)
}

But LocalizedStringKey only works in SwiftUI. (It needs to be resolved in SwiftUI.EnvironmentValues under the hood internally)

And once you get a LocalizedStringKey by StringLiteral, you can't get back the original string. So we can't do the following code as a fallback solution.

public init(
	identifier: PaneIdentifier,
	title: LocalizedStringKye,
	toolbarIcon: NSImage,
	contentView: () -> Content
) {
	self.identifier = identifier
	self.title = NSLocalizedString(title.xx, comment: "")
	self.toolbarIcon = toolbarIcon
	self.content = contentView()
}

So I'll just close the issue now until we have some SwiftUI View to consume the title property in the future.

from settings.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.