GithubHelp home page GithubHelp logo

Add glob support about trash HOT 6 CLOSED

sindresorhus avatar sindresorhus commented on September 1, 2024
Add glob support

from trash.

Comments (6)

sotojuan avatar sotojuan commented on September 1, 2024

I'll give this a shot this weekend. Doesn't seem so bad!

from trash.

sotojuan avatar sotojuan commented on September 1, 2024

Question: Should the glob support be automatic or should the user supply an option? I got it working, but it doesn't match 'weird\\\\name\\"\'' because of the /s. It makes globby think it's a directory listing. Since it doesn't find one, it doesn't delete the file.

from trash.

sotojuan avatar sotojuan commented on September 1, 2024

Sorry if you're busy Sindre, but let me know what you think of this _ The "weird name" test is the only issue, assuming automatic globbing.

from trash.

sindresorhus avatar sindresorhus commented on September 1, 2024

Yes, should be just automatic. To fix the mentioned problem we should set nonull: true in globby.

https://github.com/isaacs/node-glob#comparisons-to-other-fnmatchglob-implementations

from trash.

sotojuan avatar sotojuan commented on September 1, 2024

Thanks. Expect a PR soon!

from trash.

kevva avatar kevva commented on September 1, 2024

Fixed in ccd8d52.

from trash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.