GithubHelp home page GithubHelp logo

Accept a string about trash HOT 6 CLOSED

sindresorhus avatar sindresorhus commented on July 28, 2024 1
Accept a string

from trash.

Comments (6)

jdalton avatar jdalton commented on July 28, 2024

I'll create a PR 🎁

from trash.

sindresorhus avatar sindresorhus commented on July 28, 2024

That is a breaking change though. I'd rather just check for a string and convert it to an array.

from trash.

jdalton avatar jdalton commented on July 28, 2024

That's essentially what the PR will do. It uses the [].concat() approach of globby. It doesn't technically allow a generic iterator at that point, but you also don't have any unit tests for that behavior either.

It's also 😎 to do a small patch for v4 and bump a v5 to align more closer with globby.
I'll finish up the PR with unit tests this evening.

from trash.

sindresorhus avatar sindresorhus commented on July 28, 2024

But I have documented that it supports a "generic" iterator. I don't think it's worth doing a major bump for just this. Checking for a string is simple enough.

from trash.

jdalton avatar jdalton commented on July 28, 2024

But I have documented that it supports a "generic" iterator. I don't think it's worth doing a major bump for just this. Checking for a string is simple enough.

I've prepped a patch for both ways, though I think a v5 goal of aligning with globby isn't a bad thing.

from trash.

jdalton avatar jdalton commented on July 28, 2024

Moved to #55.

from trash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.