Comments (5)
Trash doesn't touch or cache process.cwd()
. You also do some weird stuff by comparing the function process.cwd
(not the returned value) against itself, in your test case. I don't understand what your test case is proving, but happy to take another look if you submit an actual failing test.
from trash.
Sorry I tried to prepare an ava
test but couldn't. So I'd love if you can spare me for that.
Speaking of comparing function refs, I ran the same script file with require('trash')
replaced with require('chalk')
and some others, and function refs didn't change.
So essentially the test case proves that the real process.cwd()
isn't up-to-date with actual value but it's reference const cwd
is.
For example: If the path to app.js
before running it is /xyz/app/app.js
and at runtime you perform a rename
such that it changes to /xyz/app-renamed/app.js
what do you expect process.cwd()
to return? the former or latter?
The latter of course, but it returns the former instead.
from trash.
Sorry, not much I can do until you can provide a minimal test-case that reproduces the issue.
from trash.
Actually, there is one place in trash that changes the cwd
: https://github.com/sindresorhus/trash/blob/master/test.js#L10. But it only happens if the test.js
file is called (e.g. when running npm test
in that directory)...
from trash.
I explored this further and can say it's not trash, I tried more packages and some of them show same problem (although not saying they cause it). It might be nodejs runtime, it could be something else.
from trash.
Related Issues (20)
- can not use in win32 os HOT 1
- Remove from trash bin? HOT 1
- Confusion for Windows + WSL HOT 2
- zsh: command not found: trash HOT 2
- Trouble deteting some files HOT 3
- Trashing a file on Windows deletes it unrecoverably if no recycle bin is enabled HOT 5
- Error on Linux if user never deleted any files HOT 2
- feat: read the recycle bin/trash folder HOT 1
- ERR_REQUIRE_ESM when including this in another project HOT 2
- A quote about express
- The import Trash will report ERROR HOT 1
- Webpack is not supported HOT 1
- no such built-in module HOT 2
- Contribution π¬: Perhaps 'procfs' dependency isn't really needed? HOT 1
- θ½ζδΎθΏεε ι€ηζΉζ³ε Can you provide a method for restoring deletion HOT 1
- On Windows, whose trash is used? HOT 1
- Doesn't find correct Trash folder on NixOS
- Files are renamed to a hash in KDE HOT 1
- Windows support no Win 7? HOT 1
- Readme should mention how to include the binaries HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trash.