Comments (3)
@joeldenning I'm using single-spa-react, so I don't ever call parcel.unmount
on my side manually. It gets unmounted because the parent react component gets unmounted, and then tries to unmount again in the same tick of the event loop when the route changes. I've put a bandaid in for now where I get a reference to the parcel and I poll the status until it is in the MOUNTED
state. But its not a scalable fix - we will share many components cross-MFE, and we will run into this issue again and again. It seems like parcel should be able to handle if a call to unmount comes in while it is in the UNMOUNTING
state
from single-spa.
I don't think a change to single-spa is necessary here, since parcel.getStatus()
can be called to check whether the parcel is ready to unmount:
if (parcel.getStatus() === "MOUNTED") {
parcel.unmount();
}
I'm open to discussing changing the related internal single-spa logic, but don't see why it's necessary
from single-spa.
Hi @bkfarnsworth, sorry for the late reply. We were/are working on internal improvements. I will take a look at the issue.
from single-spa.
Related Issues (20)
- The call to the assets of microfrontend fails because its a different port HOT 2
- Drop IE11 support
- Question: Is it possible to consume via single-spa webpack5 based federated micro frontends and vice versa?
- TypeError in Safari: createElementVNode is not a function HOT 5
- Questions about routing HOT 4
- Is this a solution for Vite ESM? HOT 4
- Rework navigation cancelation
- How to merge large application with single spa HOT 1
- Single-spa is always appending index.html to the URL HOT 4
- react query cache stay untouched after switching application HOT 8
- PROPOSAL: single-spa CLI HOT 5
- Adding styleguide to Nuxt app with single-spa
- PROPOSAL: Add the posibility of recycle micro-apps styles, after those are unmounted HOT 1
- Fixed component flickers during trasition between MFEs HOT 1
- Catching Runtime Error so user isn't bothered HOT 3
- Cannot use dts-bundle-generator with single-spa HOT 1
- Parcel use in a migrated react project to single-spa HOT 2
- Issue with updating divs containing single-spa apps via AJAX HOT 3
- Logging SystemJS Error#3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from single-spa.