Comments (13)
I don't think I ever made a release, did I? It's possible I merged a PR that broke a test, or more likely that it's a dependency issue? I haven't worked on it much recently, but happy to take PRs still at very least :)
from openpgp-php.
There was a release of 0.2.0. All the tests pass but it doesn't work in php 7.1 because it is using an old version of phpseclib.
I am trying to figure out what is wrong with the tests on master. I am no PGP expert so it's pretty difficult.
It seems to be the problem with the decrypt method. It is possible that phpseclib is getting called wrong now that it is using a new version.
Call to a member function equals() on string
C:\projects\work\openpgp-php\vendor\phpseclib\phpseclib\phpseclib\Crypt\RSA.php:2091
C:\projects\work\openpgp-php\vendor\phpseclib\phpseclib\phpseclib\Crypt\RSA.php:2264
C:\projects\work\openpgp-php\vendor\phpseclib\phpseclib\phpseclib\Crypt\RSA.php:2779
C:\projects\work\openpgp-php\vendor\phpseclib\phpseclib\phpseclib\Crypt\RSA.php:2987
C:\projects\work\openpgp-php\lib\openpgp_crypt_rsa.php:130
C:\projects\work\openpgp-php\lib\openpgp.php:679
C:\projects\work\openpgp-php\lib\openpgp_crypt_rsa.php:130
C:\projects\work\openpgp-php\tests\phpseclib_suite.php:37
Any pointers for trying to figure this out?
I am running these tests in php 7.0 to try and narrow down the issue.
from openpgp-php.
Is it any different/better on PHP 5.x ?
from openpgp-php.
Okay after hopping through each version I found that commit 6d9ed34 "Less strict phpseclib requirement" causes the tests to fail.
If you could make a release on the commit before de41f14 "Throw exception if using CAST5 without mcrypt" then we should have a working php 7.1 release.
from openpgp-php.
I have not tested below 7.1 and 7.0 however. I should be able to tests those later today
from openpgp-php.
@jgallavin if you instead take HEAD and edit composer.json
to depend on exactly phpseclib 2.0.0
does that also work for you?
from openpgp-php.
Alright, it seems the problems started with the release of 2.0.3
I am going to push a commit soon which changes the version restriction for now until the breaking change can be identified.
from openpgp-php.
I'll chat with upstream about this phpseclib/phpseclib#1113
from openpgp-php.
I can confirm the latest commit works with phpseclib 2.0.0.
from openpgp-php.
Perfect, thanks. I've merged the new version constraints, so you should be able to use master again now :)
from openpgp-php.
Can we make this a release to packagist? Everything seems to be working.
from openpgp-php.
what is packagist? Can you just depend on the github directly?
from openpgp-php.
Your package is already on packagist. It has over 2k installs there. It would be important to release to packagist along with the repo. composer require singpolyma/openpgp-php will install the old version and not have the updated phpseclib.
https://packagist.org/packages/singpolyma/openpgp-php
from openpgp-php.
Related Issues (20)
- Can't decrypt pgp ciphers from other clients HOT 1
- Encryption HOT 1
- PHP8 and thoughts on minimum PHP version HOT 2
- New tagged release version HOT 3
- Cant decrypt on CLI HOT 1
- Encrypt stream or chunks
- Not an asymmetrically encrypted message when trying to decrypt
- Support for phpseclib3 HOT 4
- Bump version to php 7.3? HOT 1
- Generated public keys cannot be imported into Thunderbird OpenPGP Key Manager HOT 6
- Need help with decrypting a file HOT 1
- getCipher algo number 1 HOT 1
- Please implement a "sop" (Stateless OpenPGP Command Line) interface HOT 2
- Multiple recipients when should be single HOT 3
- Error: Ciphertext representative out of range HOT 1
- Does this work out-the-box with laravel? HOT 9
- OpenPGP_PublicSubkeyPacket in SubKey exemple? HOT 1
- Documentation? HOT 1
- Cannot decrypt messages encoded with GPG
- encrypt and sign HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openpgp-php.