GithubHelp home page GithubHelp logo

Comments (4)

akkornel avatar akkornel commented on May 26, 2024

Can I add one?

• If the bootstrap fails during the %test portion, keep the container image anyway, so that the user can get to the container and check stuff out.

from singularityhub.github.io.

vsoch avatar vsoch commented on May 26, 2024

hmm, I think it would make sense to add an option to just disable the test. I wouldn't want an image to return as being successful given that test fails, unless the user specifically asked for the build with test disabled (and thus knows about this.) Would that seem reasonable?

from singularityhub.github.io.

akkornel avatar akkornel commented on May 26, 2024

Blargh, that's a good question.

I think, as an end user, I would at least want to see the log of the failure, to help understand what went wrong. It would also be nice if I could get ahold of the bootstrapped-but-untested image, so that I could mount it and dig into it (that's especially helpful if my tests don't output good error messages). But, even though I would have access to the failed image, I wouldn't want other people to get to it.

As for a "Allow failing tests?" type of setting, I'd say that they should just disable the tests in their bootstrap file.

from singularityhub.github.io.

vsoch avatar vsoch commented on May 26, 2024

@akkornel I'm going to close the issue - the %test bit can be controlled by the user, and the others are all set. Feel free to open again if I'm missing something.

from singularityhub.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.