GithubHelp home page GithubHelp logo

Comments (5)

sirbrillig avatar sirbrillig commented on May 18, 2024

Thanks for the report!

from phpcs-variable-analysis.

gmazzap avatar gmazzap commented on May 18, 2024

I think the fix actually broke used variables check inside foreach.

In my code I have:

foreach ($callbacks as $callback) {
  $callback();
 }

Which causes a:

WARNING | Unused variable $callback.

But I could notify that there are a lot of things that now raise unused variables false positive for variable declared by foreach.

from phpcs-variable-analysis.

gmazzap avatar gmazzap commented on May 18, 2024

Not sure if I should I open another issue, or maybe you could re-open this.

from phpcs-variable-analysis.

sirbrillig avatar sirbrillig commented on May 18, 2024

D'oh! I guess these unit tests are not good enough to prevent regressions. 😭 Well, we'll make them better.

from phpcs-variable-analysis.

sirbrillig avatar sirbrillig commented on May 18, 2024

Sorry about that. There's still one bug I'm tracking in #37 but 2.0.7 should fix the major bug.

from phpcs-variable-analysis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.