Feature request embedded audio and video about youtube-tui

[Siriusmart]

so how it works is that the entire tui rerenders itself every second when a song is playing, as there is no partial rendering feature in the crate im using

this ofc will increase resource usage and stuff, but since the image is only thing that takes resources to render, and it is only rerendered when absolutely nesessary, the performance impact is still near 0

[Siriusmart]

progress update, its done, but still cannot be published to crates.io for reasons
https://github.com/Siriusmart/youtube-tui/releases/tag/v0.8.0

[Siriusmart]

working on it

[Siriusmart]

heres my current progress

prop and sprop (set prop) are the custom commands i added, but loadfile and stop are default libmpv commands

now all i need to add is a message bar progress line and now-playing info thing, and the rest can be done using command bindings

2023-08-19.15-15-24.mp4

[ryanmusante]

Omg thats awesome! I love it

[Siriusmart]

2023-08-23.21-52-35.mp4

case closed, embedded video player stuff will not implement, because it already works perfectly

[Siriusmart]

so thats latest git, im gonna refine some config and messages (such as the incorrect "player resumed") before pushing to crates.io, oh and i almost forgot to write docs

btw the audio player stops when tui exits, as expected

[Siriusmart]

also if u see the tui panicking when reaching the end of songs, sometimes, just note that its fixed, not commited yet

the error is on this line and it actually happens because there is an integer overflow when seeker len is not large enough, and .repeat() just decided to put a basically infinitely large string into ram

in short, the current latest git is not stable, you'll most likely get interrupted by crashes every few minutes, so dont use it

[ryanmusante]

The issue with keybindings is gone && your work on embedded is amazing! Great work!

[ryanmusante]

It's not just good, it's phenomenal!

[Siriusmart]

ty, i took some inspirations from other tuis like darkhz's invidtui, who suggested the same feature on reddit a while back but i didnt feel like doing it

anyways enjoy