GithubHelp home page GithubHelp logo

Comments (5)

sirupsen avatar sirupsen commented on May 22, 2024

You are right—the current behaviour isn't exactly nice. I'm leaning towards printing a warning with logrus in the case where either of those keys exist—and still override it.

Alternatives would be to prefix the builtin ones with _, but that's messy and I think in most cases people won't override those. The one you'd be most tempted to override feels like Level—but even that is confusing.

What do you think of that?

from logrus.

aybabtme avatar aybabtme commented on May 22, 2024

Because they're always there, I'd make them fields on the Entry struct instead of values in the map.

from logrus.

sirupsen avatar sirupsen commented on May 22, 2024

That makes sense—what happens if they're set in the map though? Ignored? Still printed?

from logrus.

aybabtme avatar aybabtme commented on May 22, 2024

Still printed, they'd be fields like any other.

from logrus.

sirupsen avatar sirupsen commented on May 22, 2024

We discussed this in person and decided to leave it as is for now.

from logrus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.