GithubHelp home page GithubHelp logo

Comments (4)

sirupsen avatar sirupsen commented on May 17, 2024

Good catch @aarondl. This is definitely a bug, I'll look into it.

from logrus.

sirupsen avatar sirupsen commented on May 17, 2024

This can be changed for sure. I originally did this instead of just calling fmt.Sprintln because I didn't want a newline at the end, and I thought that's all it did. Newlines don't make sense when you're treating the message as a value.

What do you think about having the same concatenation rules, but still leaving out the newline?

from logrus.

aarondl avatar aarondl commented on May 17, 2024

Of course, the newlines are not what we want in a logging package. You'll notice Go's log package already has this behavior: http://golang.org/src/pkg/log/log.go#L124

So what you've mentioned is perfect :D

from logrus.

sirupsen avatar sirupsen commented on May 17, 2024

Alright, fixed in #26. Let me know if everything looks good to you :)

from logrus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.