GithubHelp home page GithubHelp logo

Comments (6)

roy-mor avatar roy-mor commented on May 14, 2024 2

@thecodeboss OK good. I wanted to make sure. Please go ahead and create a pull request for this. Please make sure to add appropriate tests for your change. Thank you!

from graphql2rest.

shuffledex avatar shuffledex commented on May 14, 2024 1

We need that PR ASAP!

from graphql2rest.

roy-mor avatar roy-mor commented on May 14, 2024

Thanks for this issue @thecodeboss.

Just to clarify - what you specified under "You should get a GraphQL error like the following" is the current behavior, yes? Which is a problem because the API user specified an integer value for the query parameter, but it got interpreted as a string, thereby violating the schema and so the input validation failed, resulting in an API request with valid input failing to execute?

from graphql2rest.

MatthewHerbst avatar MatthewHerbst commented on May 14, 2024

Just to clarify - what you specified under "You should get a GraphQL error like the following" is the current behavior, yes? Which is a problem because the API user specified an integer value for the query parameter, but it got interpreted as a string, thereby violating the schema and so the input validation failed, resulting in an API request with valid input failing to execute?

Yes, that's the current behavior. The steps above are listed under a Steps to Reproduce heading

from graphql2rest.

thecodeboss avatar thecodeboss commented on May 14, 2024

Just to clarify - what you specified under "You should get a GraphQL error like the following" is the current behavior, yes?

Yes

from graphql2rest.

roy-mor avatar roy-mor commented on May 14, 2024

@thecodeboss any progress on your suggested PR?

from graphql2rest.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.