Ignoring exlude path when it's the only child of parent about unicorn

[kamsar]

I'll take a look when I get a chance. Thanks for the clear problem statement :)

[kamsar]

Hi Kevin,

I'm having trouble reproducing this issue. I set up an example tree like you had:

I serialized all of those items.

Then I set my predicate configuration to this:
<include database="master" path="/sitecore/templates/Sites/Configuration"> <exclude path="/sitecore/templates/Sites/Configuration/Online Services" /> </include>

Next I deleted the ignored items from the disk (Online Services and its children) and ran a sync. As expected, the sync worked correctly.

Then, following your steps, I deleted the Configuration folder from the file system and then ran a sync. It seems like in your case Unicorn deleted both Specifications and Online Services items during the sync. In my case, it only deleted Specifications.

The loader does evaluate both the source data and the serialized data when evaluating orphans, as seen in this excerpt from SerializationLoader.cs (185-203):

// get the corresponding item from Sitecore
ISourceItem rootItem = SourceDataProvider.GetItemById(rootSerializedItem.DatabaseName, rootSerializedItem.Id);

// we add all of the root item's direct children to the "maybe orphan" list (we'll remove them as we find matching serialized children)
if (rootItem != null)
{
    var rootChildren = rootItem.Children;
    foreach (ISourceItem child in rootChildren)
    {
        // if the preset includes the child add it to the orphan-candidate list (if we don't deserialize it below, it will be marked orphan)
       // [ADDED] Here is where source items that are excluded (e.g. this example) are removed from the list of items to possibly delete
        var included = Predicate.Includes(child);
        if (included.IsIncluded)
            orphanCandidates[child.Id] = child;
        else
        {
            Logger.SkippedItem(child, Predicate.GetType().Name, included.Justification ?? string.Empty);
        }
    }
}

Am I missing something on reproducing this?

[kevinbrechbuehl]

Hi Kam,

thanks for looking into this. When you delete the Configuration folder from the disk, can you try to also delete the Specifications folder in Sitecore? Then run a sync. The sync fails, if I have on the disk only the Configuration.item (as you also have) and in Sitecore only the folder Configuration with it's child Online Services (but without the Specifications).

It seems that it only doesn't work if the excluded path item (Online Services) is the only child of an item included in the sync (Configuration).

[kamsar]

Hi Kevin,

I was able to reproduce the issue and have fixed it in version 2.0.2 that is on NuGet now :)

Let me know if it doesn't work for you.