GithubHelp home page GithubHelp logo

Add pep8 like codes about ansible-testing HOT 2 CLOSED

sivel avatar sivel commented on May 29, 2024
Add pep8 like codes

from ansible-testing.

Comments (2)

sivel avatar sivel commented on May 29, 2024

Thinking something like:

E1 - Locations
  1. Interpreter line is not #!/usr/bin/python
  2. main() not at the bottom of the file
  3. Missing GPLv3 license header in module
  4. Missing __init__.py
E2 - Imports
  1. Module does not import ansible.module_utils.basic
  2. Modules should not import requests, instead use ansible.module_utils.urls
  3. Use of sys.exit() instead of exit_json or fail_json
  4. Powershell module missing WANT_JSON
  5. Powershell module missing POWERSHELL_COMMON
E3 - Documentation
  1. DOCUMENTATION Missing
  2. DOCUMENTATION is invalid YAML
  3. DOCUMENTATION incorrect schema
  4. EXAMPLES Missing
  5. RETURN Missing for new modules
  6. RETURN is invalid YAML
  7. New modules have the correct version_added
  8. New arguments have the correct version_added
E4 - Syntax
  1. Invalid Python Syntax
  2. Tabbed indentation

from ansible-testing.

gundalow avatar gundalow commented on May 29, 2024

This is now tracked as ansible/ansible#18187

Can you please close this issue?

from ansible-testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.