Some async commands hang indefinitely about child_process

[huw]

These seem particularly fishy — I would've thought you should be cleaning up the async regardless?

child_process/lib/spawn.js

Lines 188 to 200 in 84c34a2

	onEnd: function onEnd(code, signal) {
	if (!result.killed) {
	// flush remaining data
	onStdout(child.fileHandle.readDataToEndOfFile())
	onStderr(child.errFileHandle.readDataToEndOfFile())
	result.emit('close', code, signal)
	result.stderr.emit('close')
	result.stdout.emit('close')
	cleanupAsync()
	}
	}

child_process/lib/spawn.js

Lines 217 to 224 in 84c34a2

	result.kill = function kill(signal) {
	if (!result.killed) {
	result.killed = true
	result.emit('close', null, signal)
	child.kill()
	cleanupAsync()
	}
	}

[mathieudutour]

not sure what you mean by "regardless"? Do you see a case where it could not be cleaned up?

[mathieudutour]

I think I found the bug, could you check with 0.3.1?

[huw]

You are a genius and your fix totally worked! As a bonus I can see stderr now :)

Cheers man!