Comments (6)
Yep, that was something I did consider, but didn't think it would fit in the "important" category.
But, yes, thanks for pointing this out, I'll figure some way to disable/enable those warnings (only one at present, but could expand).
Yes, could be thought some build symbol, like HOMOG2D_NOCHECKS
. But needs to be different, because users may want to keep runtime checkings but without bothering about such warnings.
I leave this issue open until fixed (should be fast).
from homog2d.
Yes, yes, of course it doesn't fall into the "important" category. It is a rather minor detail. Don't worry. And in fact even I myself am able to get around the problem with my limited knowledge. 😀
There are other things, such as the concept of the "Unit Vector", that I have missed much more. Lines and segments lack "directionality", and so I had to find a way to obtain angles between "vectors" (-PI,+PI).
But I suspect that the decision not to work with vectors was deliberate on your part, and has to do with the homog2d philosophy. 🗼
DJuego
from homog2d.
ok, added HOMOG2D_NOWARNINGS
build symbol, check https://github.com/skramm/homog2d/blob/master/docs/homog2d_manual.md#112---build-options (and define that symbol in your code), let me know if ok so I can close.
There are other things, such as the concept of the "Unit Vector", that I have missed much more. Lines and segments lack "directionality", and so I had to find a way to obtain angles between "vectors" (-PI,+PI).
But I suspect that the decision not to work with vectors was deliberate on your part, and has to do with the homog2d philosophy.
Exactly, that's the point ;-) Segments are just... segments, not vectors. Sure, adding a Vector
type would ultimately be possible, but I can't elaborate on this at present, I'd rather spend time on improving/fixing the existing codebase.
from homog2d.
I suspected as much. Anyway it's the main feature I've missed in homog2d. And I think it very much deserves to be included in your to-do list.
If you don't feel it as incompatible or alien in homog2d universe then I will open an issue to make formal request for that feature,
So at least it will have a chance to see the light of day. :-)
Thank you again, @skramm
DJuego
PS:
And thank you very much for implementing HOMOG2D_NOWARNINGS, it looks great! I can't test it properly at the moment but as soon as I do you will hear from me. :-)
from homog2d.
Sorry for the delay!
I tested it yesterday and I can confirm that it seems to work great. :-D You can close this thread with the feature request fulfilled.
Again, thank you! 😘
DJuego
from homog2d.
Great!
About the directionality issue you mentioned, I have thought about some ideas, but I'm not sure I understand your needs. Don't hesitate to open an issue describing exactly the feature you think is missing, and how it could be used, from a user point of view.
from homog2d.
Related Issues (8)
- CPolygon enclosing not correctly detected HOT 4
- Compilation issues in MSVS 17.8.3 HOT 6
- compilation error on msvc 19.28 HOT 7
- Question about planned features HOT 1
- Compatibility with c++17 HOT 15
- MSVC2019: Build fails - Problems with code linkage. HOT 9
- [feature request] estimation of a homography from two ellipses
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from homog2d.