Comments (4)
Can we just turn it off by default? For daily plantuml edit work and with many uml fragment files to process, this splash is just annoying, which is not needed once environment is setup. I was thinking to propose a nosplash option for this (example implementation in https://github.com/abcdec/plantuml-mode/blob/nosplash/plantuml-mode.el - look for plantuml-splash)
Introducing a generic java flag is probably still a good idea, but in such case I'd say please make it a list of string, not just string, since otherwise call-process/start-process cannot use it in case users want to specify multiple options. A string with space delimited options will create issue similar to plantuml-java-command case that you pointed out. For windows support especially use of call-process/start-process would be somehow preferred...
from plantuml-mode.
@abcdec: I'm all for turning it off by default. IMHO such splash screens are totally inappropriate for command-line tools. That's why I suggested to make this the default value for plantuml-java-flags
. Good point on making this a list, though.
I don't think using -splash:no
and -splash:yes
as in your linked implementation is correct. The java
man page states:
-splash:imgname
Shows the splash screen with the image specified by imgname.
For example, to show the splash.gif file from the images
directory when starting your application, use the following option:
-splash:images/splash.gif
Therefore using -splash:no
only works if there is no image file called no
in the current directory, and -splash:yes
will just attempt to display the file yes
.
from plantuml-mode.
I agree with both keeping the execution headless[1] by default and to have a common customizable source for command line arguments. Please checkout the feature/nosplash branch and let me know if it works for you as well (in the past, anything that fiddled with command line arguments proved shady especially if you factor in Windows support).
Also, if you happen to have have some elisp background please code-review my changes, as I'm still a white belt in this field.
[1] I have one concern, that PlantUML authors wouldn't approve of hiding their splash. But I have found no evidence to substantiate such a statement. For future reference: dear @plantuml, feel free to comment and I'll be happy to consider reverting this change.
from plantuml-mode.
After your code reviews, I have already merged all the code in master. v1.1.0
should reach MELPA soon.
from plantuml-mode.
Related Issues (20)
- Vertical split preview HOT 5
- Only display stdout in preview HOT 5
- Difficulty configuring plantuml-mode despite scouring the README HOT 3
- plantuml jar exec mode HOT 2
- plantuml-mode function to create figure HOT 1
- Configuring exec mode does not have effect HOT 1
- use server exec-mode,this error:the plugin you are using seems to generated a bad URL. HOT 11
- Cannot donload plantuml -jar due XML Not Well-Formed HOT 1
- Refactor regular expressions used for font-locking HOT 2
- indentation breaks after note anchored to method HOT 2
- indentation breaks after named multiline note HOT 2
- Syntax errors on wrong line HOT 2
- --illegal-access=deny; support was removed HOT 3
- Feature Request: plantuml toggle display toggle on or off as message
- No Syntax Highlight
- 📢📢 Seeking New Maintainer 📢📢 HOT 6
- plantuml-mode accumulates spurious tabs HOT 1
- Failed to run plantuml in an org-babel src block HOT 1
- base64 encoding not supported by plantuml pico server HOT 2
- Bug: Comment Highlighting Applied Within Lines
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plantuml-mode.