GithubHelp home page GithubHelp logo

404 behavior of /live/<user_ids> about skylines HOT 3 OPEN

vicb avatar vicb commented on July 20, 2024
404 behavior of /live/

from skylines.

Comments (3)

vicb avatar vicb commented on July 20, 2024

Hey @Turbo87, do you have an opinion about this request.

The problem on the client side is that if one of the id is incorrect (typo / wrong id) then no position are returned for the correct ids and there is error allowing to figure out the wrong id.

I could work on improving the API if we can agree on the best solution.

Thanks.

from skylines.

Turbo87 avatar Turbo87 commented on July 20, 2024

I could see this being useful, but this should be considered a breaking change for the API. We would need to adjust the SkyLines frontend to handled that case first too. Since the frontend deploys automatically after merging it would probably be best to implement that in two PRs (one for frontend, one for backend), and then merge the frontend PR first, which should support both API variants.

from skylines.

vicb avatar vicb commented on July 20, 2024

Thanks for your answer.

Could you point me to where this endpoint is used in the frontend ? (I am not familiar with that part of the code).

An other option is to add a query parameter or http header to enable the new behavior. That way there would be no breaking change. It might be preferable so that we do not break any external app querying the endpoint.

I you think that last proposal makes sense, please let me know if you prefer a parameter or header. I kind of like the header but no other endpoints use that so may be a parameter would be more consistent ? (i.e. ?lenient=true)

from skylines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.