Pan Modal does not respect definesPresentationContext about panmodal

[f0rr0]

Hey, @osdnk can you please explain what you did in your lib to make this work? Is the link mentioned in the comment still pointing to the relevant line?

[ste57]

Hi @cdstamper

Apologies for the delayed response & thanks for reporting. Unfortunately, I don't think the issue around definesPresentationContext being respected across child view controllers is specific to this library. From what I understand, this is a bug within the iOS presentation API - when using .custom as the presentationStyle - we don't automatically get the first VC in the hierarchy that has definesPresentationContext set to true. Specific to PanModal, since we rely pretty heavily on a custom presentationController, it would be pretty difficult to support an overCurrentContext type style without having to directly manipulate the presentingViewController's own view hierarchy - which can lead to unexpected results.

Let me know if this answers your question.
Stephen

[danqing]

+1 on overCurrentContext. I'm trying to do a modal that looks like what's in Apple Maps - a UIVisualEffectsView that has the presenting VC blurred underneath. This isn't possible with the current set up.

[Datastore24Kirill]

+1

[osdnk]

You're always welcome to do reparenting ¯_(ツ)_/¯
I made it workable with some workaround in my lib (bindings for PanModal for RN)
https://github.com/osdnk/react-native-slack-bottom-sheet/blob/master/ios/UIViewController%2BPanModalPresenter.swift#L25