Comments (6)
Also, the column names have spaces around them, but the data is tab separated:
Steming from
and maybe
Extra spaces should not be added, because they make any automatic processing on the tables much more complicated.
Being addressed in PR #171.
from slicerdmri.
default RAS vs. LPS convention
FYI @jhlegarreta - with Yogesh and Lauren we decided that FiberBundles are always RAS. See
from slicerdmri.
FYI @jhlegarreta - with Yogesh and Lauren we decided that FiberBundles are always RAS. See
Yes, I recall some past RAS vs LPS issue, and although I mentioned it, it is only another hypothesis; I ignore how the baseline data was generated.
from slicerdmri.
The same differences are observed when computing the measures using the GUI in 3D Slicer 5.2.2.
The relevant classes in SlicerDMRI have not been modified in the past few years (e.g. no relevant changes in the past 7 years in https://github.com/SlicerDMRI/SlicerDMRI/blame/master/Modules/CLI/FiberTractMeasurements/FiberTractMeasurements.cxx).
Following #123 (comment), 3D Slicer 4.11 and SlicerDMRI commit a7a9bdd is the last known version where tests were passing.
So, checking out that commit and seeing if tests pass (even against a recent, e.g. HEAD
, 3D slicer version) might be worthwhile.
Otherwise, a non-negligible amount of work will be needed to investigate whether differences introduced in 3D Slicer since version 4.11 (versions around 2020/09/30 or 2021/02/26) have somehow impacted that the fiber measurement computations in SlicerDMRI.
from slicerdmri.
Checking out a7a9bdd (last commit in the PR #123 commit series) does not compile; the most recent commit after that compiling is d1b8f17 (with some manual workaround in qSlicerTractographyInteractiveSeedingModule::helpText
to avoid Slicer_VERSION_MAJOR
and Slicer_VERSION_MINOR
being sought).
At d1b8f17, the tests still fail, giving the exact same results as they give with the current HEAD
.
Inspecting the commit history in SlicerDMRI, the only major change that may have impacted the measures seems
5902dee#diff-c04d96ea387b465cf4fc784b01112a62b6256677e69d2024abad79d1238467b1R28
However, commenting out that line does not make tests pass.
Otherwise, the only relevant change to the classes actually performing the computations, FiberTractMeasurements
or vtkDiffusionTensorMathematics
, seems to have been:
Slicer/Slicer@3a4f3cb
Or maybe fe29099, but it does not seem likely that random numbers are involved in the computations (e.g. like to downsample the number of streamlines or vertices - each test file has only a handful of streamlines).
So there is some other issue.
Tests have been known to be failing since early April 2023, at least.
We should create some basic tests using data whose DTI features we know very well (e.g. spheres, ellipsoids, etc.), otherwise this looks hard to solve without more context.
from slicerdmri.
Baselines will need to be updated after PR #171 has been merged.
from slicerdmri.
Related Issues (20)
- Glyphs not showing in 2D views
- Fiber bundle selection with custom function
- improve rendering using the ambient occlusion HOT 1
- SlicerDMRI build errors with C++17 HOT 3
- Update modules to use markups instead of annotations HOT 2
- build error due to default parameter in Markups ROI method
- Threat detected in SlicerDMRI HOT 1
- Apply the `FiberTractMeasurements` module to tractography data loaded into Slicer
- `Filename` field empty when loading tractography data as `FiberBundle`s HOT 2
- Load scene into Slicer with empty vtk errors HOT 2
- Provide class and and method documentation HOT 1
- Tests failing due to probably import sorting issues HOT 1
- Tests using `FiberBundleFile` data are failing HOT 5
- Remove use of deprcated "active" camera attribute in MRML scenes used in tests
- Memory leaks reported in tests HOT 12
- Doxygen ignores CLI and Scripted modules
- Tractography Display of Scalars on Fiber Bundles is not working HOT 1
- Qt methods not wrapped correctly HOT 1
- cmake error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slicerdmri.