Comments (3)
Thanks for the explanation! Makes total sense, lets do it then 🚀
from sloth.
Hi @proffalken!
Indeed! This was intended. As you saw, the validation has the discovery of manifests on directories, it only needs to validate and doesn't have an output, so it's safe to do it.
On the other part, the generator needs an output and we can't ask the user where to place the rules, so not allowing to do this was a way of avoiding this complexity (on the code and on the user).
Thinking about it, maybe we could manage something easy for the user with some validations, we could allow the user using a directory as output and use the same names as the input specs for the outputs, what do you think?
from sloth.
@slok that makes sense, thanks.
FWIW, this is exactly what the bash script I've written to wrap around Sloth does.
We start out with a directory structure similar to the following:
.
└── services
├── api
│ └── response_rate.slo.yaml
├── database
│ └── slow_queries.slo.yaml
└── vector
└── log_processing.slo.yaml
and end up with the following after running the script:
.
├── prom_alerts
│ └── services
│ ├── api
│ │ └── response_rate.slo.yaml
│ ├── database
│ │ └── slow_queries.slo.yaml
│ └── vector
│ └── log_processing.slo.yaml
└── services
├── api
│ └── response_rate.slo.yaml
├── database
│ └── slow_queries.slo.yaml
└── vector
└── log_processing.slo.yaml
where prom_alerts
contains the Sloth output. We then use cortextool to upload these prometheus alert rules to Grafana cloud in the next step of our CI pipeline, but we never commit the output from Sloth to Git so we can be confident we're always generating new values.
The ability to pass it an --input-dir
and --output-dir
when running sloth generate
would be awesome, but we have a workaround for now :)
from sloth.
Related Issues (20)
- How can I reset the error budget remaining to 100 for 7 days from 30days HOT 3
- Option to generate sloth yaml - using 5m record rule chaining
- Sloth Alerting Rules Not Firing - Graphs Empty on Query Test HOT 1
- Help on Latency SLO definition HOT 1
- Testing an operator which manages Sloth SLOs HOT 1
- Question: Is there a way to refer totalQuery via template variable in errorQuery
- promql expr validation issues HOT 2
- Overriding the `sloth_id` doesn't work
- Feature Request: Provision SLOs from Helm install HOT 2
- Issues making Sloth work with Google Managed Prometheus HOT 1
- what does the current remaining buget -4.69e -12% mean in sloth HOT 2
- Alerting expression changes in Prometheus Alerts browser HOT 1
- 🔴 Project Status HOT 9
- Confusing definitions of errorQuery and totalQuery
- Have you considered creating 'totalQuery' as a recording rule as well?
- grafana dashboard broken for SLOs with dots in the name
- error: "generate" command failed: invalid spec, could not load with any of the supported spec types HOT 1
- How can one add a weekly maintenance window into the calculations for SLO's with sloth? HOT 1
- NaN in SLO dashboard HOT 5
- Sloth pod is not showing SLO metrics HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sloth.