Incorrect parsing in `read_tables._extract_fixed_width_field_data()` about pds4_tools

[LevN0]

Ethan, thank you for reporting.

For ease of debugging, could you include your label and data file? Either upload it here or email me with it by clicking on the link with my name here.

[eischaefer]

Ethan, thank you for reporting.

For ease of debugging, could you include your label and data file? Either upload it here or email me with it by clicking on the link with my name here.

I have now e-mailed you links to the label and data.

[LevN0]

Thank you. We should confirm that we agree in terms of how group fields should be defined according to the PDS4 standard.

Could you take a look at how the record_length, the group_location and group_length fields are defined in the aforementioned links, and let me know if this is also how your values are expressed in the label?

[eischaefer]

Thank you for your attention. There is no bug.

I am migrating some PDS3 labels to PDS4 and the original label incorrectly provides ITEM_BYTES and ITEM_OFFSET in bits, not bytes. The software that I created to facilitate that migration correctly catches the misstatement for ITEM_BYTES, and consequently <field_length> is correct, but does not correct ITEM_OFFSET, and therefore <group_length> was incorrect in the initial PDS4 label.

I have since fixed that bug and the updated PDS4 label is correctly read by the PDS4 Tools code.

Incidentally, I find your code very clean and well documented! Thank you for that.

[LevN0]

Ethan, glad you found the problem and appreciate the complement. Once upon a time a lot of work went into this code.