GithubHelp home page GithubHelp logo

Comments (6)

jmandel avatar jmandel commented on August 19, 2024
  1. I don't see any reason to support asymmetric client authentication in IE.

  2. It's not just "recommended" - my understanding is that IndeedDb is the only technically valid way to persist non extractable keys. But we could handle this case in the ways you suggest (allowing args to ready, or storing this particular property in IndexedDb).

  3. Good call. It's okay to require a CryptoKey and an additional alg parameter if we need that to disambiguate.

  4. As in (3) -- could even combine these into a publicJwk argument, which would have the full public key, alg, and kid...

from client-js.

vlad-ignatov avatar vlad-ignatov commented on August 19, 2024

So, we could start with something like this:

interface ReadyOptions {
    privateKey?: JWK | {
        key: CryptoKey
        alg: "RS384" | "ES384"
        kid: string
    };
    clientPublicKeySetUrl?: string; // for jku
    [key: string]: any; // Other options TBD
}

FHIR.oauth2.ready({
    privateKey: {
        key: CryptoKeyObject,
        alg: "RS384",
        kid: "1234"
    },
    clientPublicKeySetUrl: "https://whatever"
}).then(client => ... )

Then, depending on if and how people use that, we may also consider IndexedDb.

My only question so far is why did you name this "publicJwk argument" above, instead of private - by mistake, or am I missing something?

from client-js.

jmandel avatar jmandel commented on August 19, 2024

So, we could start with something like this

Yes, that would be a safe way to start

My only question so far is why did you name this "publicJwk argument" above, instead of private - by mistake, or am I missing something?

Oh, I was suggesting something like

FHIR.oauth2.ready({
    privateKey:  CryptoKeyObject,
    publicJwk: {
      "kty": "EC",
      "kid": "3Kfdg-XwP-7gXyywtUfUADwBumDOPKMQx-iELL11W9s",
      "use": "sig",
      "alg": "ES256",
      "crv": "P-256",
      "x": "11XvRWy1I2S0EyJlyf_bWfw_TQ5CJJNLw78bHXNxcgw",
      "y": "eZXwxvO1hvCY0KucrPfKo7yAyMT6Ajc3N7OkAB6VYy8",
    },
    clientPublicKeySetUrl: "https://whatever"

Just because the algorithm and the KID are already defined in that data model, but I am not pushing strongly for this suggestion.

from client-js.

vlad-ignatov avatar vlad-ignatov commented on August 19, 2024

Looks like we are talking about the same thing. In my example, if privateKey has a key property, then it should have the shape { key: CryptoKey, alg: "RS384" | "ES384", kid: string }. Otherwise, privateKey is expected to be valid JWK having alg, kid and everything else.

What confuses me is that you have both privateKey and publicJwk. What is the idea behind using these together and why is that jwk public?

from client-js.

jmandel avatar jmandel commented on August 19, 2024

Your suggestion works well! (I hadn't fully understood it when I suggested separately supplying the alg/kid in the context of a public key input.)

from client-js.

vlad-ignatov avatar vlad-ignatov commented on August 19, 2024

This is now released in v2.5.0

from client-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.