Comments (9)
That's how it's supposed to work. Custom partials should be under app/views/exception_notifier directory, as it explains on the "Customization" part of the README.
Please, correct me if I'm not understanding your issue.
from exception_notification.
My custom partial is in app/views/exception_notifier. The problem is that exception_notifier doesn't seem to find it unless I make the change shown in my message. (See the 2nd and 3rd lines of my code.)
So it looks like exception_notifier is doing render 'user', which doesn't have the /exception_notifier/ part of the path.
Maybe it would have been clearer if I had written
summary = render("exception_notifier/#{section}")
above.
Said more succinctly, exception_notifier does not find my custom partial, which is in the right place, as written. I had to modify it (exception_notifier) to find my partial.
Am I making any sense?
from exception_notification.
You need to add the path manually e.g. in your initializer file (config/initializers/exception_notifier.rb), like
ExceptionNotifier::Notifier.prepend_view_path File.join(Rails.root, 'app/views')
Maybe this could be done internally, since the documentation instructs to just add views to your /app/views and nothing else?
from exception_notification.
Thanks, bostrom...so I'm not crazy.
I'll see if I can't change this in the code and submit a pull request.
from exception_notification.
hey @scrozier @bostrom, is this fixed already? Can I close this issue?
from exception_notification.
Not to my knowledge. I haven't checked the code, but at the time of my last comment it didn't work the way the documentation said. So IMO either add the 'app/views' path by default in the code or update the documentation to instruct users to add it manually like I did in my previous comment.
from exception_notification.
@smartinez87, no, I don't think it's fixed. I was waiting for some feedback from you, but I think @bostrom and I are in agreement that it's still broken.
I will get on this and submit a pull request today or tomorrow.
from exception_notification.
Just submitted a pull request.
Thanks to @bostrom for a clean solution. I was taking a somewhat less elegant approach. :-)
from exception_notification.
pull request #50 fixes this issue, so I'm closing this.
from exception_notification.
Related Issues (20)
- Sinatra Example Not Working HOT 1
- Matrix implementation
- cannot load such file -- exception_notification (LoadError) HOT 10
- No way to tell which rails environment the error came from
- Error on Rails 6.1 for Rails.application.class.parent_name.underscore HOT 2
- SNS Notifier Data Attribute
- New exception to add to ignored_exceptions HOT 2
- Secret_key_base is leaking through the email HOT 5
- link in the readme IS NOT AVAILABLE HOT 1
- Access to env through `notification_trigger` callback
- Add ability to control how exceptions are grouped for error_grouping HOT 1
- HTTP Authorization Header
- Additional data doesn't show in teams notification HOT 3
- Ignore_notifier_if settings are not respected in non-Rack usages such as background jobs. HOT 1
- Rails 7 is out ! HOT 4
- Psych 4 incompatible HOT 1
- Update rubocop configuration
- Gem's package includes `examples` directory
- Rails 7 API only exception not working HOT 3
- Google Chat is not sending error notification
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from exception_notification.