Comments (11)
You should pass an empty array to the 'ignore exceptions' option, like this:
Whatever::Application.config.middleware.use ExceptionNotifier,
:email_prefix => "[Whatever] ",
:sender_address => %{"notifier" [email protected]},
:exception_recipients => %w{[email protected]},
:ignore_exceptions => []
from exception_notification.
Thanks, but I already tried this, but it keep not sending email for a RoutingError, that's why I asked :(
According to the code, it should but it is not working. I still don't know why.
from exception_notification.
Sanity check: did you check the logs?
from exception_notification.
Yes, in production.log I see the exceptions, I saw the call to the plugin when I have an error other that default a,d the mail is sent without problem. I can see the configuration which looks like ok :
- exception_notifier.options : {:sender_address=>""_" <_t>", :exception_recipients=>"[email protected]", :email_prefix=>"[_*] ", :sections=>["request", "session", "environment", "backtrace"], :ignore_exceptions=>[]}
But nothing happen with a RoutingError.
from exception_notification.
I'm having the same issue as AlexandreK. Passing an empty array does not make exception_notification send an email. My logs definitely show a 404 error took place.
from exception_notification.
Can you provide a failing test for this?
Passing an empty array does make sending the notification in some sample apps I have.
from exception_notification.
@Alexandrek @aroc any update on this issue? Have you tried on the release candidate?
Please provide a sample app / failing test if it keeps happening to you, I'm not being able to reproduce this.
from exception_notification.
Closing this issue. Feel free to re-open it if you're still facing it.
from exception_notification.
This is still the case for rails 3.2.13. Passing an empty array to ignore_exceptions won't send an email for the errors that are ignored by default, such as RecordNotFound and RoutingError.
from exception_notification.
Hey @smartinez87, this is definitely still an issue. I think the problem is the below method. It makes it impossible to ever get notifications for the default ignored exceptions.
def ignored_exception?(ignore_array, exception)
(Array(ignored_exceptions) + Array(ignore_array)).map(&:to_s).include?(exception.class.name)
end
from exception_notification.
I added ::ExceptionNotifier.ignored_exceptions = []
after my ::ExceptionNotification
config to get this to work.
from exception_notification.
Related Issues (20)
- No way to tell which rails environment the error came from
- Error on Rails 6.1 for Rails.application.class.parent_name.underscore HOT 2
- SNS Notifier Data Attribute
- New exception to add to ignored_exceptions HOT 2
- Secret_key_base is leaking through the email HOT 5
- link in the readme IS NOT AVAILABLE HOT 1
- Access to env through `notification_trigger` callback
- Add ability to control how exceptions are grouped for error_grouping HOT 1
- HTTP Authorization Header
- Additional data doesn't show in teams notification HOT 3
- Ignore_notifier_if settings are not respected in non-Rack usages such as background jobs. HOT 1
- Rails 7 is out ! HOT 4
- Psych 4 incompatible HOT 1
- Update rubocop configuration
- Gem's package includes `examples` directory
- Rails 7 API only exception not working HOT 3
- Google Chat is not sending error notification
- Can't find stack trace in the email notification HOT 1
- Error counts for grouped exception notifications are updated inconsistently, causing duplicate alerts
- Add new default exception to ignore for Rack::Utils::InvalidParameterError
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from exception_notification.