Background notification not working with delayed_job about exception_notification

[smartinez87]

You think you can work out a Pull Request for this?

[victorbueno]

Working on it right now. =)

[bragma]

Any update on this? I'd like to send emails through dealyed_job.
I've checked victorbueno's repository, he patched background_notification to use delay instead of deliver. This has not been pushed into this repository and it seems that the official gem grabs from here. For my deploy I prefer using official gems.
Any solutions to this? Will the change be pulled?

[emiltin]

is this working now?
can i set delayed_job as the default, or do i need to manually call exception_notification() with the relevant option?

[threadhead]

+1

[smartinez87]

IMO, this is rather a DelayedJob issue.
ExceptionNotification is implemented according Action Mailer API.
I don't want to do a work around to make it work with other's work around. Plus it will only work with DJ if I do so, breaking it for other background job processing libraries.

[moiristo]

Wouldn't it just work by wrapping the notification with an instance method?

class User < ActiveRecord::Base
  def signup!
    Notifier.signup(self).deliver
  end
end

@user.delay.signup!

or in a more generic form:

class User < ActiveRecord::Base
  def async_notify(notification)
    Notifier.send(notification, self).deliver
  end
end

@user.delay.async_notify(:signup)

[smartinez87]

which is why you can do

ExceptionNotifier::Notifier.delay.background_exception_notification(e)

outside, not having to change the gem's code