GithubHelp home page GithubHelp logo

Comments (19)

romainruaud avatar romainruaud commented on June 19, 2024 2

I just came back from vacations, I'll try to find some time this week to release a new version of this module.

Regards

from magento2-module-elasticsuite-shared-catalog.

davidstillson avatar davidstillson commented on June 19, 2024

I second this request/bug.. can't install 2.9.0 because of composer dependency conflicts

from magento2-module-elasticsuite-shared-catalog.

a-dite avatar a-dite commented on June 19, 2024

Same here
Problem 1 - Installation request for smile/module-elasticsuite-shared-catalog ^1.1.0 -> satisfiable by smile/module-elasticsuite-shared-catalog[1.1.0]. - Can only install one of: smile/elasticsuite[2.9.0, 2.8.x-dev]. - Can only install one of: smile/elasticsuite[2.9.x-dev, 2.8.x-dev]. - Conclusion: install smile/elasticsuite 2.8.x-dev - Installation request for smile/elasticsuite ~2.9.0 -> satisfiable by smile/elasticsuite[2.9.0, 2.9.x-dev].

from magento2-module-elasticsuite-shared-catalog.

duffner avatar duffner commented on June 19, 2024

@romainruaud, can you please take a look at this? This is an issue for us as well

from magento2-module-elasticsuite-shared-catalog.

trebb0r avatar trebb0r commented on June 19, 2024

Or maybe @androshchuk or anyone at Smile that can help out?

from magento2-module-elasticsuite-shared-catalog.

rbayet avatar rbayet commented on June 19, 2024

Hello guys,

Until we find a proper solution, have you tried cheating with composer and installing Elasticsuite with composer require smile/elasticsuite 2.9.0 as 2.8.7 for instance ?
I know I used this trick when I wanted a M2 2.3.5 / Elasticsuite 2.9.0 with https://github.com/Smile-SA/elasticsuite-for-retailer.

(I offer no guarantee of compatibility yet, but this solves the composer issue).

Regards,

from magento2-module-elasticsuite-shared-catalog.

actionis avatar actionis commented on June 19, 2024

Will this be compatible with 2.9.0?

Is it just a matter of updating the requirements for smile/elasticsuite in composer.json?

from magento2-module-elasticsuite-shared-catalog.

skukla avatar skukla commented on June 19, 2024

Is there any chance of these modules being updated? Given that ES 6.x is now deprecated in Magento 2.4.0 (although not yet officially), it would be great to be able to use the most up-to-date version of Elasticsuite together with Magento's native B2B functionality.

from magento2-module-elasticsuite-shared-catalog.

romainruaud avatar romainruaud commented on June 19, 2024

Guys,

I don't want to be rude but please keep in mind that we are providing all of these modules for free, and on an Open Source License. This means that you can also participate and submit pull requests to make this module evolve as fast as you need.

If you only want to take benefits of it without helping, that's fine too, but you'll have to accept that we may have some delay.

Regards

from magento2-module-elasticsuite-shared-catalog.

davidstillson avatar davidstillson commented on June 19, 2024

@romainruaud Not rude at all, it's good to know that you will accept PRs for this.. What is the typical turn around for you guys to code review/release? Is there a preferred process or format for any PRs submitted?

from magento2-module-elasticsuite-shared-catalog.

skukla avatar skukla commented on June 19, 2024

As @davidstillson points out, not rude at all, and I apologize if my comment came off harshly. Smile is one of the best agencies I have seen at responding to requests like this and I took that for granted in this case. Seeing others ask whether this was supported in 2.9.x had me concerned that support for B2B might have been dropped.

@romainruaud, Thanks for the update and as always, thanks to you and the Smile team for the effort and work on this product.

from magento2-module-elasticsuite-shared-catalog.

romainruaud avatar romainruaud commented on June 19, 2024

You can just create a pull request pointing to master, this repository is tiny and does not have all the complex validation rules (Travis builds, unit testing etc...) of the ElasticSuite core repository.

I'll gladly review it after my vacations, but in any cases, I think the composer trick given by @rbayet could help you installing the module at least. I don't know however if this would be fully functional.

Regards

from magento2-module-elasticsuite-shared-catalog.

skukla avatar skukla commented on June 19, 2024

Hi all. Given that I'm not a developer, it's often difficult for me to find ways to contribute back to projects like this; however, I've just done some testing and thought it might be helpful if I reported back what I learned:

  1. @rbayet's suggestion of using a composer alias does allow for the B2B modules to be installed with the latest version of Elasticsearch (~2.10.0); however, in my testing, this only works when one includes the require statement in one's composer.json as opposed to an inline composer require statement. (E.g. running the following from the command line produced an error: composer require smile/elasticsuite 2.10.0 as 2.8.7; but using it in my composer.json file worked fine).
  2. With the modules installed and the proper search engine configured, Elasticsuite works: results are returned via typeahead. However, product image thumbnails are not included in the typeahead results.

That's as far as I've dug in thus far. Hopefully it's helpful.

from magento2-module-elasticsuite-shared-catalog.

adamchukandrii avatar adamchukandrii commented on June 19, 2024

Hello, @romainruaud. Is there any news on this issue?

from magento2-module-elasticsuite-shared-catalog.

adamchukandrii avatar adamchukandrii commented on June 19, 2024

Thanks

from magento2-module-elasticsuite-shared-catalog.

romainruaud avatar romainruaud commented on June 19, 2024

Please try the 1.1.1 version, which is intended to allow Elasticsuite 2.8 or 2.9 with Magento 2.3.x versions.

If that's okay I'll also release a version allowing Elasticsuite 2.10 for Magento 2.4.x versions.

Thanks

from magento2-module-elasticsuite-shared-catalog.

adamchukandrii avatar adamchukandrii commented on June 19, 2024

Looks like all is ok. Thank you

from magento2-module-elasticsuite-shared-catalog.

rbayet avatar rbayet commented on June 19, 2024

@romainruaud Should we close this one ?

from magento2-module-elasticsuite-shared-catalog.

rbayet avatar rbayet commented on June 19, 2024

Hello @skukla (and others),

I've just published a 2.10.0 release which is compatible afaik with Magento 2.4.1 / Elasticsuite 2.10.2 / B2B features 1.3.x.
It simply contain a different Elasticsuite requirement.

Same thing for new releases 2.6.0, 2.8.0 and 2.9.0 releases which are strictly the same thing code-wise as, respectively, releases 1.0.1, 1.1.0 and 1.1.1.

We've decided to adopt the same pattern of version numbers as Elasticsuite for this module and for the Elasticsuite Quick Order module to help identify Magento2 / Elasticsuite compatibility.
I have no illusion that Magento is totally capable of punching us in the face real hard with the next minor 2.3.x and 2.4.x releases, but where's the fun otherwise ? :)

Regards,

from magento2-module-elasticsuite-shared-catalog.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.