Consider switching from mmap to memmap about wayland-kbd

[vberger]

Hmm, yeah indeed. Thanks for pointing this out.

I'll tackle this as soon as I have some time, it should be pretty straightforward.

[vberger]

Hmm... After some digging, I can't find a way to create a memory-map from a linux file descriptor in memmap-rs, which is exactly the feature I'm using in mmap: https://github.com/vberger/wayland-kbd/blob/master/src/mapped_keyboard.rs#L153-L156

[retep998]

@danburkert Nudge, nudge.

[retep998]

Wait, you can do this already. On unix platforms you have FromRawFd impl'd on File so you can use that to get a File which you can then pass to memmap.

[danburkert]

Yah the Mmap::open_with_offset function should work. That being said, I've never tested against non-file-backed 'files'.

[vberger]

Fair point. I'll try this tomorrow.

[frewsxcv]

@vberger Did you ever look into this? Did it end up being non-trivial?

[vberger]

Hmm, kinda forgot this, sorry for that...

I won't have time to spend on it for the next two weeks unfortunately... :-/

[frewsxcv]

I won't have time to spend on it for the next two weeks unfortunately... :-/

All good!

Opened a PR for this whenever you have time: #9