GithubHelp home page GithubHelp logo

Delayed construction. about async-channel HOT 3 CLOSED

smol-rs avatar smol-rs commented on August 19, 2024
Delayed construction.

from async-channel.

Comments (3)

 avatar commented on August 19, 2024 1

Turns out this was an issue in event-listener: smol-rs/event-listener@3142ee7

Event has a built-in mechanism for delayed construction. However, when Sender or Receiver is dropped, the channel becomes closed. Closing notifies all Events and their listeners. The problem here is that notifying would initialize Events, which is pretty expensive. But there's no point in initializing when notifying! If Event is uninitialized when notified, that means there are no EventListeners to notify. :)

Updating to event-listener v2.3.1 brings construction of a channel from ~1000ns to ~250ns on my 2020 macbook pro.

from async-channel.

 avatar commented on August 19, 2024

That is certainly a little steep, I would expect 5x smaller numbers... If you're never actually using channels that's a big price to pay just for channel construction + destruction. Anyways, regarding channel construction:

  • bounded::<T>(n) allocates something like [(T, usize); n] on the heap
  • unbounded::<T>() allocates something like [(T, usize; 32] on the heap

I think those allocations could certainly be delayed, it'd just be a bit of work :)

from async-channel.

jjl avatar jjl commented on August 19, 2024

For comparison, a ConcurrentQueue is ~200ns to create and destroy on the same box, so I was a bit surprised by this. I'll take a look at some point, but it's pretty low priority right now.

from async-channel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.