toMatch overrides the existing Jest toMatch about jest-puppeteer

[gregberge]

The actual behaviour is the following:

• If expect() has a Page or a ElementHandle instance, it uses jest matchers + expectPuppeteer matchers
• If expect() has another thing, it uses jest matchers

https://github.com/smooth-code/jest-puppeteer/blob/master/packages/expect-puppeteer/src/index.js#L87

So the toMatch depends of the type provided in expect(), I don't know if it is possible in TypeScript but it is possible in JavaScript 😏.

[gregberge]

Yes, but who want to call toMatch on a Page or an ElementHandle?

[JoshuaKGoldberg]

I was under the impression this overrides the existing toMatch, which means you can no longer use the existing one. Is that not the case?

Either way, the TypeScript type system won't allow conflicting definitions, so jest-puppeteer's version of toMatch can't go into the typings. At the very least this breaks TypeScript users.