GithubHelp home page GithubHelp logo

Comments (5)

JohnSully avatar JohnSully commented on May 29, 2024 1

I appreciate you taking the time to look at it!

I'm available on the gitter chat as well.

If you have autotools installed then my best guess is its finding the system's memkind headers or you didn't do a "make distclean". There's a bug where sometimes memkind fails to incrementally recompile. I don't modify memkind frequently so I haven't been motivated to fix that yet :)

Regardless once I have a CentOS machine up I can look in more detail. I need to finish up with issue #27 first.

from keydb.

JohnSully avatar JohnSully commented on May 29, 2024

Its important to note that the memkind used in KeyDB is a patched version with extra functionality. KeyDB will not compile with an official version unless it also has the necessary changes. These aren't trivial things, but rather additionally functionality to support fork(), and preventing the leaking of disk space.

memkind_tmpfile is one such example of additional APIs I've had to add.

If you are able to post the build results of that perhaps I can help now. Otherwise I will try on centos in the next few days.

Edit: Also should mention I do want to eventually upstream the changes, but there's a lot of things higher on the priority list right now.

from keydb.

fmunteanu avatar fmunteanu commented on May 29, 2024

@JohnSully let's wait when you are available, I can provide you the source rpm with all needed files. It will compile fine with MALLOC=jemalloc switch but fail with MALLOC=memkind switch. We could work together on this, for now I will release it with jemalloc enabled.

from keydb.

fmunteanu avatar fmunteanu commented on May 29, 2024

I'm going to make also the missing man files for all keydb binaries.

from keydb.

JohnSully avatar JohnSully commented on May 29, 2024

Had a chance to look at CentOS 6. The kernel on my fresh install is 2.6.32 which does not have the FICLONE ioctl needed for the memkind allocator to work. I believe 4.5 is the minimum kernel that can support it. Given that I don't believe the memkind allocator can be enabled unless CentOS decides to update their kernel.

I've fixed the PRIu64 issue that was referenced in another CentOS bug.

Please reopen if there are any other issues I haven't addressed.

from keydb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.