GithubHelp home page GithubHelp logo

Comments (4)

snarfed avatar snarfed commented on July 23, 2024

huh. thanks for filing!

i actually suspect we're handling retweets wrong more broadly. we should probably render them as coming from the original author, with the original text, as opposed to from the retweeter and with the "RT author ..."

i thought we were doing this right, by extracting retweeted_status for RTs at twitter.py:837. details in the twitter docs.

...however, if that was the cause here, i'd think the link would be moved up to start before the http://t.co, not after. so i still don't know what's up yet either.

from granary.

snarfed avatar snarfed commented on July 23, 2024

here's the RT in the example above: https://twitter.com/EvaGabriela_Z/status/507570782126358528

and the original tweet: https://twitter.com/jeresig/status/507528866513293315

from granary.

snarfed avatar snarfed commented on July 23, 2024

i took a look at this, and i think we should do three things:

  • fully convert retweeted_status to an embedded object in the outer share ActivityStreams object. (right now we only fill in a minimal set of fields, e.g. url)
  • use the content text from that embedded object, when available, instead of the text we're using that includes RT @author .... this should fix the links.
  • improve the mf2 html rendering for retweets/shares. specifically, render the original tweet as a reply context, outside the e-context. @barnabywalters actually asked for this a bit ago for shrewdness.

these will take some work, mostly in ramping up on the twitter conversion code (even for me), but they'll be worth it.

i don't plan to work on this soon, so anyone else is welcome to!

from granary.

snarfed avatar snarfed commented on July 23, 2024

this got fixed recently. that tweet's e-content is now rendered as:

RT <a href="https://twitter.com/jeresig">@jeresig</a>: ... This one is great: <a href="http://geekfeminism.wikia.com/wiki/How_to_find_supportive_workplaces">geekfeminism.wikia.com/wiki/How_to_fi…</a>

from granary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.