GithubHelp home page GithubHelp logo

Light mode broken about snoopwpf HOT 22 CLOSED

mo-russo avatar mo-russo commented on June 12, 2024
Light mode broken

from snoopwpf.

Comments (22)

batzen avatar batzen commented on June 12, 2024 1

@joce Our call was very helpful.
I finally found a way to reproduce the issue.

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

Does that happen with every application you attach to?

from snoopwpf.

mo-russo avatar mo-russo commented on June 12, 2024

I just upgrade to the latest this morning, started my application, snooped it and it was like that. Didn't do anything special.
The Dark mode works properly though which I'm using right now as a workaround.

edit And yes, it seems to be happening only in a specific application.

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

Would it be possible to share your application?

from snoopwpf.

mo-russo avatar mo-russo commented on June 12, 2024

Unfortunately no, it's not my application but my employer's. I can't distribute it.

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

That'll make it more difficult to fix as i can't reproduce the issue on my machine.

Could you try to snoop Snoop via the "Debug" menu and have a look at the colors Snoop is using?

It looks like, at least, the foreground color seems to be overwritten by the app being snooped, which usually shouldn't be possible as Snoop already does quite a lot to prevent that from happening.

from snoopwpf.

NMBSdtayloe avatar NMBSdtayloe commented on June 12, 2024

It does this on my machine as well, but malfunctions in Windows dark mode, and works correctly in light mode (I did install the program with dark mode enabled). I can confirm that it is application specific as well, testing it in other apps leads to correct results. Unfortunately my app is also not distributable.
image

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

Could you try to use the debug menu in Snoop and choose "Snoop Snoop".
After that inspect the Snoop UI itself, have a look at the foreground property of one of the elements in the grid which has a wrong foreground?
The foreground should reference to the resource key "Snoop.Brushes.Default.Foreground".
Something in your application seems to influence that value.

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

@NMBSdtayloe @mo-russo Have you tried the above to provide some information on the cause for this issue?

from snoopwpf.

NMBSdtayloe avatar NMBSdtayloe commented on June 12, 2024

@batzen Can you provide some guidance for how and where this value would be found? I did "Snoop Snoop" and this is maybe what you are looking for. I put a red box around an instance of the foreground brush you mentioned.
image

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

@NMBSdtayloe You have to inspect the TextBlock which has the wrong foreground while in dark mode and being attached to your application.

from snoopwpf.

NMBSdtayloe avatar NMBSdtayloe commented on June 12, 2024

These are some of the instances of textblock in my app. I apologize in advance, I do not have any experience in using snoop or digging through the treeview of a WPF app. I searched for textblock again later and somehow got more results and sometimes just a flat list or it selects the first random textblock it finds.
image

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

@NMBSdtayloe Is there a chance we can meet via Zoom, Skype, Teams or something like that? Then you could share your screen and I could tell you what you have to do to narrow down the issue.

from snoopwpf.

EgilSandfeld avatar EgilSandfeld commented on June 12, 2024

Have you guys tried version 4.0.1? Just tested 5.0.2 vs 4.0.1 and on my end this issue happens after 4.0.1. Maybe the error regressed?

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

I changed quite a lot of the theme code etc. So it's most likely a regression, but as long as there is no repro I can't fix it as it happens with none of the apps I tried.
@EgilSandfeld do you have a repro?

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

@EgilSandfeld @mo-russo @NMBSdtayloe ping

from snoopwpf.

joce avatar joce commented on June 12, 2024

@batzen Have you made any progress on this? I'm having the same issue.
However, same as the other users, I can't distribute the app I'm snooping, but I'm willing to help.

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

@joce i still haven't seen an app causing this issue, so there is sadly still no fix or progress.
Could you follow the steps from #397 (comment) or would you be available for a call so we can narrow down the cause?

from snoopwpf.

joce avatar joce commented on June 12, 2024

Err. Even doing Snoop Snoop, I get the same issue!

image

from snoopwpf.

joce avatar joce commented on June 12, 2024

As others pointed out, it works fine when in Dark Mode on my side as well.

image

Can't you repro when you're in default app mode is Light Mode?

from snoopwpf.

batzen avatar batzen commented on June 12, 2024

This is what i get when using light mode system wide and attaching Snoop:
image

from snoopwpf.

joce avatar joce commented on June 12, 2024

Interesting.
I DM'd you on twitter to book a Zoom appointment.

from snoopwpf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.